educelab / volume-cartographer

Volumetric processing toolkit and C++ libraries for the recovery and restoration of damaged cultural materials
GNU General Public License v3.0
63 stars 22 forks source link

OFS V2 Beta #34

Closed schillij95 closed 11 months ago

schillij95 commented 1 year ago

Hi Seth & all!

This is VC with OFS V2. Improvements:

The code is not very clean, but it is working and public for everyone to use!

Cheers

csparker247 commented 1 year ago

Thanks! FYI, I'm traveling for work over the next few weeks, so I'm not sure when I'll be able to review this, but I'm very excited.

We may want to try to break this apart into a few PRs so it's easier to track if it inadvertently breaks something. If it's possible for you to break some of these features apart into separate pull requests, that would greatly speed up review.

csparker247 commented 1 year ago

@schillij95 You've been quite busy. I'd really like to get some of these new features merged into the upstream, but I really can't review ~4k lines of code changes for an assortment of features. Any chance you can work on breaking these out into separate pull requests soon?

csparker247 commented 11 months ago

There are a number of desirable features in this (and other forks), but the code needs to be properly reviewed before it can be merged. Closing this until someone is able to sort through the changes.