Get rid of "jdbcConnectionTest" warning when using Play configuration

[julien-lafont]

When HikariCP is configured through play application.conf, a warning is always displayed in the console.

[warn] c.z.h.HikariConfig - The jdbcConnectionTest property is now deprecated, see the
documentation for connectionTestQuery

This warning is triggered when the jdbc4ConnectionTest property is setted

It's not possible to remove this warning by tweaking play configuration, due to this line which always set this property.

[megazord]

Yes, you are right.

I have plans to remove all configuration options in favor of have Hikari configured directly in application.conf file. In other words, we won't have this translation between Play properties and Hikari. I expect to work on that the next days.

[julien-lafont]

Yes it seems a good plan. It's easier to inject a custom config in tests with the Play configuration than Hikari properties.

[megazord]

Fixed at master branch.