search

edulify / play-hikaricp.edulify.com

HikariCP Plugin for Playframework 2.2.x and 2.3.x
http://edulify.github.io/play-hikaricp.edulify.com/
Apache License 2.0
82 stars 35 forks source link

Config translation for JDBC connection settings #65

Closed takezoe closed 9 years ago

takezoe commented 9 years ago

Config translation was removed at https://github.com/edulify/play-hikaricp.edulify.com/commit/ffcbc78a3762709ef3280b9a05aa64a86ab6648d. However I think it causes duplicated configuration if we use play-hikaricp with other plugins such as flyway-play because they expect default Play2 configuration.

# for play-hikaricp
dbplugin=disabled
db.default.driverClassName=com.mysql.jdbc.Driver
db.default.jdbcUrl="jdbc:mysql://localhost:3306/test"
db.default.username=root
db.default.password=""

# for flyway-play
db.default.driver=com.mysql.jdbc.Driver
db.default.url="jdbc:mysql://localhost:3306/test"
db.default.user=root

Therefore I think it's useful to provide translation for basic JDBC connection settings.

megazord commented 9 years ago

Sounds good to me, @takezoe. Could you please send a PR for this?

We could probably copy the code from Playframework itself now (version 2.4 will support HikariCP out-of-the box).

takezoe commented 9 years ago

I sent a pull request #66

megazord commented 9 years ago

PR was merged. I will close this issue after releasing a new version.

Thanks, @takezoe.

takezoe commented 9 years ago

@megazord Thanks! I'm looking forward to the next release. We really need it.

megazord commented 9 years ago

@takezoe version 2.0.5 released here:

https://github.com/edulify/play-hikaricp.edulify.com/releases/tag/2.0.5

Thanks again.