search

edumeet / edumeet-docker

eduMEET in docker container for version (4.x)
https://edumeet.org
MIT License
54 stars 42 forks source link

Ports 40000-49999/tcp #12

Closed christian-2 closed 8 months ago

christian-2 commented 4 years ago

According to Dockerfile and docker-compose.yml, mm only publishes ports 40000-49999/udp:

EXPOSE 40000-49999/udp
ports:
- "40000-49999:40000-49999/udp"

However, since mm runs with network_mode: "host" the set of actually published ports also comprises 40000-49999/tcp. These TCP ports are e.g. important for meeting participants who may traverse firewalls with openssh/SOCKS5 (and forceTcp=true). README.md (in havfo/multiparty-meeting) and roles/mm/files/ferm.conf (in misi/mm-ansible) already refer to them.

IMO they should also be listed in Dockerfile and docker-compose.yml to enhance documentation and consistency.

misi commented 4 years ago

I fully agree..

misi commented 3 years ago

network mode: host conflicts with defining ports so it is commented out in the last commit, but for documentation it is there.