Closed etiennebacher closed 2 years ago
This looks good! Thanks for the fix and test. I don't have a NEWS file yet since I actually haven't updated the original CRAN version of the package. But I should do so now given there has been a soft accumulation of bug fixes. I'll add a NEWS file when I do with your addition noted. Thanks again @etiennebacher!
This PR closes #20. It fixes a bug that appears when
synthetic_control()
hasgenerate_placebos = FALSE
and when the treated country doesn't come first in the data (see the example below).@edunford I didn't see a NEWS file, is there a place where I can add this so that users know that it is fixed in the Github version?
Currently:
Created on 2022-08-31 by the reprex package (v2.0.1)
New behavior:
Created on 2022-08-31 by the reprex package (v2.0.1)