search

edunford / tidysynth

A tidy implementation of the synthetic control method in R
Other
98 stars 14 forks source link

grab_signficance time range error #4

Closed gloriadli closed 2 years ago

gloriadli commented 3 years ago

When specifying an incorrect time frame,grab_signficance() throws the following error. In the example below, 1993 is the intervention time, thus the range does not include post-intervention data.

image

This can be replicated using the example in the readme using the following date range: smoking_out %>% grab_signficance(1970:1988).

Thanks Dr. Dunford!

edunford commented 2 years ago

Thanks again for pointing this bug out, Gloria! I've now added a check that ensures their are post-treatment observations when running grab_significance(). (afd112a57)