edunlimit / intro-data-capstone-musclehub

0 stars 0 forks source link

Summary: Exceeds Expectations #5

Open Caealana opened 6 years ago

Caealana commented 6 years ago

Overall, this was a great project!

I won't have too much to say about your code. Your code was written cleanly and efficiently, and all of your python code worked correctly towards accomplishing the various data science tasks. You followed many of the best conventions concerning indentation. This helped in making your python code easily readable. Some of your variable names could have been more specific and tailored towards the values they were holding. For example, your contingency table names could have referenced the groups you were comparing. Here is more information on python styling conventions if you are interested.

I would suggest you practice adding in your own comments and a README to this github repository to give some context to your code. Comments answer questions like 'What were you thinking when you writing this code?' and 'What is the purpose of this chunk of code? Are there currently any issues with it?" Here is a helpful guide for creating READMEs that give a good introduction to your project.

On your presentation: Your slide designs were beautiful! Your color matching for the A and B groups was a clever organization. I especially liked how you presented your chi-square results. You presented the thought process and methods clearly and in an easy to understand manner. I would just suggest having a friend check over your slides to catch small grammar mistakes. For example,

screenshot at apr 13 16-27-13

Here, the title should be "What do people say?" instead of "What does people say?"

Again, great job!

edunlimit commented 6 years ago

Thank you so much for your review it helped me a lot!