Fixed support for esm - Githubissues

eduolalo / moment-business-days

This is a momentJS plugin that allows you to use only business days (Monday to Friday)

MIT License

240 stars 67 forks source link

Fixed support for esm #103

Closed swernerx closed 2 years ago

swernerx commented 2 years ago

Updates GitHub matrix to respect only modern NodeJS LTS versions
Removed travis config + bower config (assumption is that these are not relevant anymore)
Replaced CJS code entry points (require) with ESM syntax
Updated dependencies to the newest versions
Tests are all green
Fixes support for Vite bundler

mcdado commented 2 years ago

Hi there, thank you!

The CI job won’t run against the PR with Github Actions? IIRC with travis it used to run as a PR check.

mcdado commented 2 years ago

I see that previous runs “failed” because windows-2016 is deprecated. Can you switch to windows-2019 and windows-latest only, please?

alexnault commented 2 years ago

Hey! Any progress on this? We are having issues using moment-business-days in a project configured with Vite (esbuild/rollup) since this package doesn't properly support ESM.

borislit commented 1 year ago

@mcdado was this ever released?