search

eduolalo / moment-business-days

This is a momentJS plugin that allows you to use only business days (Monday to Friday)
MIT License
240 stars 67 forks source link

fix: * import breaking with moment 2.24 #73

Closed trisrael closed 4 years ago

trisrael commented 5 years ago

When using moment@2.24 and tsc 3.5.1 These types break resulting in the project being unable to be built.

lefterisk commented 4 years ago

@mcdado can we get this merged in please? It wont compile otherwise.

lefterisk commented 4 years ago

@mcdado is there a planned release we can expect this to be in?

mcdado commented 4 years ago

Problem is that @kalmecak is AWOL. While I can merge PRs, I don't have control on the npm package. If he did respond I'd take the reins and publish more updates.

jpgarcia commented 4 years ago

Hi guys, thanks for fixing this! Is there any update regarding npm publising? Is @kalmecak still AWOL?

Thanks in advance!

eduolalo commented 4 years ago

Hi guys, I'm making the update in npm

jpgarcia commented 4 years ago

awesome! thanks @kalmecak 🚀