search

eduolalo / moment-business-days

This is a momentJS plugin that allows you to use only business days (Monday to Friday)
MIT License
240 stars 67 forks source link

Get business weeks between two dates #79

Closed ade-fatimah closed 4 years ago

ade-fatimah commented 4 years ago

This PR adds a new method businessWeeksBetween that allows users get business weeks between two dates.

mcdado commented 4 years ago

Looks good, but would you mind adding some tests with fixed dates that prove how it should behave?

ade-fatimah commented 4 years ago

Looks good, but would you mind adding some tests with fixed dates that prove how it should behave?

Done.

mcdado commented 4 years ago

I've fixed some the tests by moving them to the right place and by adding a check that they actually do what they're supposed to, let me know if that's correct!

https://github.com/kalmecak/moment-business-days/commit/af548cba8a384a11d67d2bc4575bb3bbf3e975ce