edures888 / pe

0 stars 0 forks source link

Repeating additional fields in adding student command #1

Open edures888 opened 1 year ago

edures888 commented 1 year ago

Starting with a new addressbook,

Screenshot 2023-04-14 at 14.22.42.png

By running the command, add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 s/Math sch/monday st/08:30 et/10:30 sch/tuesday st/10:00 et/12:00

it seems that the school and start/end times are replaced by the latest values.

Screenshot 2023-04-14 at 14.23.32.png

However it is not clear in the UG that there can only be one value for sch, st and et. Users might think that it would be obvious to be able to add multiple fields for school days and the respective start and end times.

Aside from this, the command format is somewhat confusing because the optional tag field can be used but it is not specified in the format, whereas the section on 'Note about the command format' does not align with this command since the optional fields are not indicated clearly.

nus-pe-script commented 1 year ago

Team's Response

There are two bugs in this issue, one is tag bug, which is a duplicated one. Another is multiple subject and schedule in the add command. I reject this as UG only specifies the ability to add multiple tags and does not say multiple subjects and schedules. image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]