edures888 / pe

0 stars 0 forks source link

Copy feature integration #5

Open edures888 opened 1 year ago

edures888 commented 1 year ago

Copy feature seems to work well as I can see the new entry. But when I restart the application, it detects the presence of duplicate students and an empty app is shown.

Screenshot 2023-04-14 at 14.47.02.png

This is what the data file looks like:

{ "persons" : [ { "name" : "Alex Yeoh", "phone" : "87438807", "email" : "alexyeoh@example.com", "address" : "Blk 30 Geylang Street 29, #06-40", "remark" : "", "subject" : "Math", "schedule" : "monday", "startTime" : "08:30", "endTime" : "09:30", "tagged" : [ "GoodEffort" ], "lessons" : [ "Meet Tutor" ], "attendanceDates" : [ ] }, { "name" : "Bernice Yu", "phone" : "99272758", "email" : "berniceyu@example.com", "address" : "Blk 30 Lorong 3 Serangoon Gardens, #07-18", "remark" : "", "subject" : "Math", "schedule" : "monday", "startTime" : "08:30", "endTime" : "11:30", "tagged" : [ "GoodEffort" ], "lessons" : [ "Meet Tutor" ], "attendanceDates" : [ ] }, { "name" : "Charlotte Oliveiro", "phone" : "93210283", "email" : "charlotte@example.com", "address" : "Blk 11 Ang Mo Kio Street 74, #11-04", "remark" : "", "subject" : "Math", "schedule" : "friday", "startTime" : "08:00", "endTime" : "10:30", "tagged" : [ "neighbours" ], "lessons" : [ "Meet Tutor" ], "attendanceDates" : [ ] }, { "name" : "David Li", "phone" : "91031282", "email" : "lidavid@example.com", "address" : "Blk 436 Serangoon Gardens Street 26, #16-43", "remark" : "", "subject" : "Math", "schedule" : "thursday", "startTime" : "08:00", "endTime" : "09:30", "tagged" : [ "family" ], "lessons" : [ "Meet Tutor" ], "attendanceDates" : [ ] }, { "name" : "Irfan Ibrahim", "phone" : "92492021", "email" : "irfan@example.com", "address" : "Blk 47 Tampines Street 20, #17-35", "remark" : "", "subject" : "Math", "schedule" : "wednesday", "startTime" : "09:30", "endTime" : "11:30", "tagged" : [ "classmates" ], "lessons" : [ "Meet Tutor" ], "attendanceDates" : [ ] }, { "name" : "Roy Balakrishnan", "phone" : "92624417", "email" : "royb@example.com", "address" : "Blk 45 Aljunied Street 85, #11-31", "remark" : "", "subject" : "Math", "schedule" : "tuesday", "startTime" : "10:30", "endTime" : "12:30", "tagged" : [ "colleagues" ], "lessons" : [ "Meet Tutor" ], "attendanceDates" : [ ] }, { "name" : "Alex Yeoh", "phone" : "87438807", "email" : "alexyeoh@example.com", "address" : "Blk 30 Geylang Street 29, #06-40", "remark" : "", "subject" : "English", "schedule" : "monday", "startTime" : "08:30", "endTime" : "10:30", "tagged" : [ "GoodEffort" ], "lessons" : [ "Meet Tutor" ], "attendanceDates" : [ ] } ] }

This is quite severe since using the copy feature will prevent future use of the application. Furthermore, since users will have to exit, with an empty application, the save feature will cause the removal of all saved data.

Screenshot 2023-04-14 at 14.49.28.png

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: I think that since the command shows an unexpected outcome, it should be a functionality bug?

Screenshot 2023-04-19 at 13.02.57.png