edures888 / pe

0 stars 0 forks source link

No response when copying with same subject and schedule #7

Open edures888 opened 1 year ago

edures888 commented 1 year ago

Screenshot 2023-04-14 at 14.54.07.png

After filtering the list with `filter n/alex', I then try to copy the Alex Yeoh's entry, but the command can't seem to run at all. There is no result indicating success or errors and the command stays in the input.

Screenshot 2023-04-14 at 14.56.42.png

Same thing occurs when I go back to the default listing by using list command and I am unable to copy the entry. This seems to happen whenever I try to insert an entry of the same subject and schedule. If this is not allowed, I think that the application should at least accept the command and warn the user.

With further probing, I can tell that there might be an implementation issue because if I tweak the command to have invalid end time, the command flashes red and shows the corresponding error message. Fixing that and trying to run the command produces the same freezing result.

Screenshot 2023-04-14 at 15.00.43.png

This would be confusing for the user and thus I think the severity is somewhat high.

nus-se-script commented 1 year ago

Team's Response

Same issue with the UG failed to mention about subject restriction, thanks for pointing out!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Copy command not functioning properly

Alex Yeoh has a Math class scheduled on Monday 08:30 - 09:30. When trying to add a new Math class on Tuesday from 13:00 - 15:00, the app freezes with no error message being produced.

Screenshot 2023-04-14 at 2.24.46 PM.png

I thought this is something you might want to consider improving since the UG mentions that users can use the copy command to "Copy an existing student to the managing system with a different subject or schedule." I interpret that the app intends to allow a student to have more than one lessons of the same subject during the week. And if you want to prohibit this, an error message should be produced to warn users from doing so.


[original: nus-cs2103-AY2223S2/pe-interim#3923] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The copy command only allows to create another entry with different subject, but the UG failed to state this.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This involves a documentation bug and a functionality bug. The duplicate would be regarding the documentation bug.


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** In my opinion, this is not just a documentation bug as this is a possible action by the user. If copy command only allows to create another entry with different subject, then it should show proper handling of the invalid command, such as 'Same subject not allowed'. The users may choose to do so as their students may not only have 1 session for each subject.
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]