search

eduridden / moodle-filter_fontawesome

1 stars 10 forks source link

Font inclusions are wrong! #5

Open gjb2048 opened 10 years ago

gjb2048 commented 10 years ago

The readme states: Your site/theme must have FontAwesome embedded already. This filter does not provide the font.

And yet there is: https://github.com/moodleman/moodle-filter_fontawesome/blob/master/styles.css#L1 - which does not work as the theme processing of URLs needs to be like this:

https://github.com/moodleman/moodle-theme_elegance/blob/master/style/elegance.css#L33-L42

Thus causing 404 network errors!

gjb2048 commented 10 years ago

More info on: https://tracker.moodle.org/browse/MDL-23493