search

edusperoni / nativescript-ripple

NativeScript plugin to add Android Material Design Ripple effect to your layouts.
Apache License 2.0
52 stars 13 forks source link

Issue #9 #11

Closed mn-martin closed 3 years ago

hauthorn commented 7 years ago

We would really like this to be a part of the plugin (perhaps even on the dev branch for testing). We run tns 3, and would love to disable the plugin on iOS.

On a related note: The "iOS support" is visually off. It doesn't conform with the material design spec, and as such is not useful.

mn-martin commented 7 years ago

@hauthorn This was for intended for NS ^2. I didn't had the time to look into this with NS ^3 yet.

bradmartin commented 7 years ago

Apologies I let this one slide by. Would either of you two be interested in being added as Collaborators to the repo so you can help maintain it?

@hauthorn @mn-martin

CC @jgraffite also to see if interested in helping.

jgraffite commented 7 years ago

Yes, @bradmartin , I will help to make this functionality (option to disable effect on iOS) to iOS working on NS 3

bradmartin commented 7 years ago

Thanks @jgraffite - you are now a collaborator on the repo so you can manage it. If anyone else wants to assist just ping me here and let me know.

hauthorn commented 7 years ago

I can help with this fix if you need me to.

bradmartin commented 7 years ago

@hauthorn you're also now a collaborator. Both of you can manage this repository now 👍

mn-martin commented 7 years ago

@bradmartin This is my work github account. My private account is: https://github.com/hettiger If you add my private account I'll help as soon as I get the chance to for sure.

jogboms commented 7 years ago

Can we continue in this direction 👍