search

edusperoni / nativescript-ripple

NativeScript plugin to add Android Material Design Ripple effect to your layouts.
Apache License 2.0
52 stars 13 forks source link

seems broken in nativescript 3.0 #12

Closed hazlanmshabli closed 7 years ago

hazlanmshabli commented 7 years ago

I am trying to use this in 3.0 and it complained about ui/core.

Dragomir-Ivanov commented 7 years ago

I need this for {N} 3 as well.

magar91 commented 7 years ago

would be really helpful for me too please. Any update if this plugin will be compatible with version 3?

bradmartin commented 7 years ago

It can, I don't have much free time right now to update it. I'll gladly accept a PR if someone wants to try updating it :) If anyone has questions and wants to contribute just let me know, always glad to answer questions :)

On Mon, May 22, 2017, 10:08 AM Andres Jimenez Rivera < notifications@github.com> wrote:

would be really helpful for me too please. Any update if this plugin will be compatible with version 3?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bradmartin/nativescript-ripple/issues/12#issuecomment-303128384, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhIndZzHUI1kPmxl4PWqCuXzQVXwmks5r8aTOgaJpZM4NTuG_ .

bradmartin commented 7 years ago

2.0.0 has been published. Thanks to @jgraffite for the great PR to update 🎉

jgraffite commented 7 years ago

You're welcome @bradmartin . My goal is keep helping and improving that plugin and all the NativeScript community with new helps and plugins

Dragomir-Ivanov commented 7 years ago

@jgraffite Thanks a lot for your help. If you have any interest, can you take a look at nativescript-contacts. It is a very useful plugin, but no {N} 3.0 support.