edusperoni / nativescript-ripple

NativeScript plugin to add Android Material Design Ripple effect to your layouts.
Apache License 2.0
52 stars 13 forks source link

Update ripple.android.ts #13

Closed jgraffite closed 7 years ago

bradmartin commented 7 years ago

@jgraffite - all working on android and iOS here? Haven't had time to go through and review all the changes yet. Let me know if it's ready and I'll do a quick test and publish for the update.

Thanks 😄

jgraffite commented 7 years ago

Hi @bradmartin ,

All working in both Android and iOS.

Some hours ago, I tested in a iOS emulator to be sure that that's working out. After that, I commited the latest modifications

Obs.: Sorry for my poor English :D

bradmartin commented 7 years ago

Thanks. Your English is fine, better than a lot of native English speaking people :) I'll review and publish later this week.

CC @jenlooper - swag reward

On Wed, May 24, 2017, 2:56 PM jgraffite notifications@github.com wrote:

Hi @bradmartin https://github.com/bradmartin ,

All working in both Android and iOS.

Some hours ago, I tested in a iOS emulator to be sure that that's working out. After that, I commited the latest modifications

Obs.: Sorry for my poor English :D

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/bradmartin/nativescript-ripple/pull/13#issuecomment-303834008, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhPUwbdAYTCm9fKFjOksjdLHJTrkfks5r9It-gaJpZM4NixHJ .

bradmartin commented 7 years ago

@jlooper ^^