Group Attributes of Class and Object elements of Google Wallet, to make it more maintainable.

edutap-eu / edutap.wallet_google

Python API to interact with Google Wallet API

https://pypi.org/project/edutap.wallet-google/

European Union Public License 1.2

4 stars 0 forks source link

Group Attributes of Class and Object elements of Google Wallet, to make it more maintainable. #6

Closed loechel closed 5 days ago

loechel commented 7 months ago

Group Attributes of Class and Object elements of Google Wallet to make it mor maintainable.

jensens commented 7 months ago

This needs also:

[ ] major version bump.
[ ] change log entry
[ ] updates in documentation repository.

loechel commented 7 months ago

@simon-lund please make a detailed review and if possible also make additional commits.

This Pull-Request changes the default behavior of eduTAP.wallet_google only to accept model attributes to be set if they are explicitly in the model. This follows PEP 20 Zen of Python: explicit is better than implicit

Each model element should have a reference to its documentation and all relevant attributes. Please check if all attributes are modeled.

jensens commented 7 months ago

Before merging, a PR to update https://github.com/edutap-eu/documentation/tree/main/source/packages/edutap_wallet_google is needed over there.