search

eduvis / eduvis.github.io

Organisation Website (as of 2020-21 - subject to change). Visit eduvis.com.au for currently relevant DNS record.
http://eduvis.com.au
GNU General Public License v3.0
0 stars 0 forks source link

Improve visual aesthetics #20

Closed Coedice closed 10 months ago

Coedice commented 11 months ago

Closes: https://github.com/eduvis/eduvis.github.io/issues/18

njsch commented 11 months ago

@Coedice, how come I cannot merge without explicitly manually overriding Branch protection rules?

Coedice commented 11 months ago

@njsch It could be because there are unresolved threads (which is right, because there are changes to be made). Typically it is the assignee who hits the merge button once the reviewer has approved the MR

njsch commented 11 months ago

Also, where is the script that used to be in the header (not head) for the customisable Google search box?

Coedice commented 11 months ago

@njsch I forgot to call this out. I had removed it, since I figured we don't have all that many pages on the website anyway.

It's also very a very ugly search bar.

Do you think we should keep it? I could add it back and see if I can improve how it looks if you think it's worth having

njsch commented 11 months ago

Oh okay. In that case, we may as well just leave it out. Thanks for clarifying.On 23 Nov 2023, at 12:13 pm, Gavin Douch @.***> wrote: @njsch I forgot to call this out. I had removed it, since I figured we don't have all that many pages on the website anyway. It's also very a very ugly search bar. Do you think we should keep it? I could add it back and see if I can improve how it looks if you think it's worth having

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

njsch commented 11 months ago

I have a hunch about this: is the 3rd-party Texture theme contained anywhere on Github or in Jekyll other than here?

Unless you're wanting it to come from somewhere else, you have to add it explicitly as a remote theme which does not appear to have been done. It might be good to compare samarsault/texture/_config.yml side-by-side with the Eduvis one as I think the switch from Minima to Texture has possibly corrupted it.

I'm sure it's not difficult to fix but this is why I have hesitated to change the theme from Minima on my personal site.

njsch commented 11 months ago

I've tried to fix it but it still won't deploy. Sorry if I should have made my own branch off yours, otherwise not sure if you may have to manually fix some merge conflicts on your own end. But the YAML file looks more consistent with what's in the main Texture repo now.

njsch commented 11 months ago

Still isn't working even after attempting to fix according to samarsault/texture issue #43.

Coedice commented 11 months ago

It looks like GitHub Pages only supports a small list of themes: https://pages.github.com/themes/

I will modify this PR to use cayman instead

njsch commented 10 months ago

Unfortunately, because I had dismissed my previous review, it appears that I couldn't re-review. So I have done a manually overridden merge commit. I know it's not ideal, maybe I should've re-requested a review myself. But I wasn't exactly sure how else to do this