search

eduvpn / android

Android eduVPN application
https://play.google.com/store/apps/details?id=nl.eduvpn.app&hl=en
GNU General Public License v3.0
129 stars 44 forks source link

Fix certificate expired notification every second #331

Closed fantostisch closed 3 years ago

fantostisch commented 3 years ago

Fixes https://github.com/eduvpn/android/issues/329 caused by 942876402d3f1d312ef6304cd12c4cd366a38956.

fantostisch commented 3 years ago

There is still a bug, stopUpdateCertExpiry will not work when updateCertCallback is running.

dzolnai commented 3 years ago

There is still a bug, stopUpdateCertExpiry will not work when updateCertCallback is running.

Will you update the pull later with an extra commit to fix this?

fantostisch commented 3 years ago

I just tested (https://github.com/fantostisch/android/commit/2de2707031539d14e49a81f9de89709e2cd36c25) to be sure and somehow onPause will not be called before updateCertExpiry is finished, so the bug I thought was there is not there. While testing I discovered that the code waits 1 second before it starts calculating the cert expiry. This is fixed in https://github.com/eduvpn/android/pull/331/commits/e4fa5b1634aa3ac74e85dbb99accfd736754db83.

ghost commented 3 years ago

Can this one be merged?

dzolnai commented 3 years ago

From my part, yes.

ghost commented 3 years ago

Thanks!