Display Let's Connect! as Let's Connect!

[jeroenleenarts]

Fixes #301

On simulator iPhone SE (1st gen) iOS 13.5 it looks good. We might want to do some more testing/checking with users with iOS 12 and adjusted font sizes.

[github-actions[bot]]

Make sure to keep CHANGES.md up to date!

[roop]

@jeroenleenarts So we keep Info.plist entry as "Let's Connect", but product name as LetsConnect. Is that correct?

[jeroenleenarts]

Yes. Only display name is allowed to contain the Let’s Connect name properly formatted.

[roop]

• Instead of APP_NAME and APP_SIMPLE_NAME, wouldn't it be better to have the xcconfig keys named as APP_NAME and APP_DISPLAY_NAME to be consistent with CFBundleName and CFBundleDisplayName? (i.e. APP_NAME = LetsConnect; APP_DISPLAY_NAME = Let's Connect)
• Is this a problem with the macOS app too? Does your fix work for both iOS and macOS?
• Can you update EduVPN/Config/Developer.xcconfig.letsconnect-template with the "Let's Connect" name?

• Should we make the template easier to understand by saying something like this?:

  APP_NAME = <app-name>
  
  // If your app display name is different, specify the display name
  APP_DISPLAY_NAME = $(APP_NAME)

[jeroenleenarts]

@roop Good feedback. I'll change that later today.

[roop]

@jeroenleenarts Does it work on macOS too? I couldn't find a CFBundleDisplayName entry in the macOS Info.plist, so am a bit confused. (I haven't tested it in iOS or macOS.)