search

eduvpn / apple

app for iOS and macOS
Other
62 stars 18 forks source link

UI Tests for iOS #364

Closed johankool closed 3 years ago

github-actions[bot] commented 3 years ago

Make sure to keep CHANGES.md up to date!

jeroenleenarts commented 3 years ago

I think code wise it is ok. But I do think we should look into storing secrets on Github. These will be made available at runtime as ENV vars. And those we can easily pickup in the UITests.

Currently I see a username, password and host. All in two flavours demo and custom.

jeroenleenarts commented 3 years ago

Also, why snake case the test names. Let's not put underscores in class names.

johankool commented 3 years ago

Also, why snake case the test names. Let's not put underscores in class names.

That's just what Xcode does when having a space in the target name. No underscores fine with me.

johankool commented 3 years ago

Currently I see a username, password and host. All in two flavours demo and custom.

Correct, we'll need to determine which servers and accounts to use for that. Creating some dedicated accounts for that would be good. For now these tests were meant to be run locally and manually.

roop commented 3 years ago

I think code wise it is ok. But I do think we should look into storing secrets on Github. These will be made available at runtime as ENV vars. And those we can easily pickup in the UITests.

Currently I see a username, password and host. All in two flavours demo and custom.

@jeroenleenarts I was thinking we can figure that out when we integrate this with a test lab to run this on, because what needs to be done might depend on the test lab's interface.