search

eduvpn / apple

app for iOS and macOS
Other
58 stars 18 forks source link

New icon colours slightly off #436

Closed FlorisFokkinga closed 1 year ago

FlorisFokkinga commented 2 years ago

Thanks for the new task bar icons. The colours are slightly off the default on macOS 12.1 (21C52). image image image

roop commented 2 years ago

Thanks for reporting this subtle issue.

I'm still using macOS 11, and I can see that the colour is off a little here as well when the wallpaper is dark (so the OS is using light colour status icons).

I've tried to fix this up by explicitly marking the images as templates:

Before the fix:

idle_before connected_before

After the fix:

idle_after connected_after

When the wallpaper is light (so the OS is using dark status icon colours), the colour is consistent with some system icons, but not with some others, which I think is acceptable:

After the fix:

idle_after connected_after
roop commented 2 years ago

Reopening this issue.

I'd like to keep this issue open until this fix is part of a release and @FlorisFokkinga is able to verify that it's fixed in macOS 12.

roop commented 1 year ago

This was released as part of 3.0.0.

Status bar icon looks good in macOS 13. (Missed verifying with macOS 12.)

FlorisFokkinga commented 1 year ago

As I remember, this was also looking fine on macOS 12. I consider it fixed.