eduvpn / apple

app for iOS and macOS
Other
58 stars 18 forks source link

expiry notification isn't aware of re-auth #445

Closed efef closed 2 years ago

efef commented 2 years ago

Screenshot 2022-03-16 at 11 42 58

yesterday evening I got session expired and now roughly 13 hours later I click "renew session" , click on "approve" but client (current Appstore version) doesn't respond to the received OAuth token.

The problem is the "session has expired" notification seems not to be integrated in the App anymore. As if, because 13 hours were passed, the App isn't fully aware of the notification state and the notification doesn't disappear however the App received the OAuth token succesfully.

When I click "ignore" the client is connected successfully.

roop commented 2 years ago

A couple of assumptions:

  1. When you got "session is expiring", I think you might have seen an alert but you didn't click anything in it then. Is that correct?
  2. After 13 hours, you said you clicked "Renew Session". I presume it was in the alert from (1). Is that correct?

If the above assumptions are correct, I suspect this is what might have happened:

roop commented 2 years ago

Closed in PR #451