search

eduvpn / eduvpn-common

Code to be shared between eduVPN clients
MIT License
5 stars 3 forks source link

V2: Combine discovery functions #18

Closed jwijenbergh closed 1 year ago

jwijenbergh commented 1 year ago

Should DiscoOrganizations and DiscoServers be combined? Why are there 2 functions?

Clients should almost always fetch them together, no?

rozmansi commented 1 year ago

Pre eduvpn-common eduVPN client for Windows: when started, it used server discovery to rearrange no-longer available Institute Access servers to Own servers and vice versa. Organization discovery is not needed for this and was triggered only if user clicks to add a new IA server or Secure Internet.

eduvpn-common based eduVPN client for Windows: when IA servers or Secure Internet is detected in old config, the server discovery is triggered. When SI is detected in old config, the organization discovery is triggered next. So, in case there were only IA servers and no SI, only the server discovery is done on startup.

jwijenbergh commented 1 year ago

right then I think we can close this due to this optimization?