search

eduvpn / eduvpn-common

Code to be shared between eduVPN clients
MIT License
5 stars 3 forks source link

Installed shared library as part of the python package #43

Closed hamarituc closed 4 months ago

hamarituc commented 4 months ago

During packaging version 1.99.2 for Gentoo Linux, I noticed the shared library is not part of the python wheel anymore. In the old setup.py where was a shutil.copyfile-instruction which got removed in 9bab3c87825b4284b3e6f2be3fa9e89da7723116. From my point of view, declaring the library as a data file should fix the problem. But I am unsure if this is the recommended solution.

jwijenbergh commented 4 months ago

Thanks for the pr, I didn't know you packaged it for gentoo, nice! Your PR looks correct, apologies for the issue.

Honestly I am super confused how all python packaging is supposed to work, there is package data, data files. Then you can supply metadata in: setup.py setup.cfg pyproject.toml MANIFEST.in

I have been thinking of moving to a split of setup.cfg and pyproject.toml + a simple setup.py (only calling setup with no args), as unfortunately only having metadata in pyproject.toml seems to be super problematic for older python versions, e.g. packaging for debian 11. I will make a PR for this soon

hamarituc commented 4 months ago

Honestly I am super confused how all python packaging is supposed to work, there is package data, data files. Then you can supply metadata in: setup.py setup.cfg pyproject.toml MANIFEST.in

You are not the only one. I am also not an expert in this matter and just found the solution which works, but I am not sure if this is the way the inventor intended.

jwijenbergh commented 4 months ago

superseded by #44