Closed frozen-sky closed 6 years ago
frozen-sky
commented
6 years ago 
joostvb-gh
commented
6 years ago Hi frozen-sky, Thanks for this nice PR. I eyeballed it and have some comments:
You do a "touch .upgrade" : there's a better way for that, e.g. something like:
case "$1" in configure) if test "x$2" = "x" && ! test -e "/etc/...." then install ....
see e.g. apt-listbugs.postinst (on debian systems in /var/lib/dpkg/info/ )
In vpn-admin-portal/debian/preinst and vpn-server-api/debian/preinst and vpn-server-node/debian/postinst and vpn-server-node/debian/preinst and vpn-user-portal/debian/rules: why /usr/share/debconf/confmodule ? unneeded imho: we don't use debconf there.
vpn-admin-portal/debian/rules and vpn-server-api/debian/rules and vpn-server-node/debian/rules : w hy override_dh_compress? i guess it's better to stick with the default here and don't override.
it would be nice if a patch for debian/changelog would also be in the pull request.
anyway, i suggest this PR gets merged.
Thanks, Bye,
Joost