eduvpn / macos

Deprecated, please go to https://github.com/eduvpn/apple
15 stars 40 forks source link

software upgrade - helper app issue #185

Closed efef closed 5 years ago

efef commented 5 years ago

when upgrading the client to the newest release, there is an helper app update issue. When the new client is run and the helper app is being upgraded this error is shown:

screen shot 2019-01-16 at 09 21 12
efef commented 5 years ago

a dirty fix is :"sudo launchctl remove org.eduvpn.app.openvpnhelper" After a while (wait) the new helper will be installed.

an other dirty fix is: "rm -fr /Library/PrivilegedHelperTools/org.eduvpn.app.openvpnhelper" upgrade goes smoothly. It makes clear there is somehow something wrong with the helper upgrade. Now to find a real fix.

theNerdFromSiliconValley commented 5 years ago

If we update the version number in OpenVPNHelper-Info.plist and HelperService.swift file, SMJobless will update the helper file automatically.

theNerdFromSiliconValley commented 5 years ago

So during each release, we have to update the version no of the helper file

efef commented 5 years ago

Is it possible to make this a build.sh functionality so it automatically will increase?

theNerdFromSiliconValley commented 5 years ago

It is not recommended since we also edited on code side

theNerdFromSiliconValley commented 5 years ago

5d597efa-3d1a-4b3f-9132-6c633af186a6 Adding this is also recommened

johankool commented 5 years ago

Is it possible to make this a build.sh functionality so it automatically will increase?

No, it is an error on the developer if this happens. The version needs to be increased when there have been changes made to the helper.

johankool commented 5 years ago

@theNerdFromSiliconValley You mention that the RunAtLoad key should be set to YES. Why is that? Did you read that somewhere?

theNerdFromSiliconValley commented 5 years ago

Yes, I saw and tested that DMG in @efef MAC ,

johankool commented 5 years ago

I don't understand your answer. Why do you think RunAtLoad should be added?

theNerdFromSiliconValley commented 5 years ago

@johankool Please check https://macadmins.psu.edu/files/2012/11/psumacconf2012-launchd.pdf

screen shot 2019-01-16 at 9 18 46 pm
johankool commented 5 years ago

Afaict RunAtLoad causes the helper to be launched after boot, instead of on demand as is done now. Since we don't use it before the eduVPN app launches that doesn't add anything.

theNerdFromSiliconValley commented 5 years ago

Ok