Add Category to desktop files

[hamarituc]

During packaging eduVPN for Gentoo Linux the distro maintainers suggested to add the category Network;Dialup to the desktop file. Currently we are applying this patch downstream, but it may be useful for other users, too. So I would like to request you considering to apply this patch upstream.

[jwijenbergh]

Thanks, makes sense to add this. Dialup is a bit strange though? Do other VPN apps use these categories?

[reneum]

I did they same for an openSUSE package. :+1: In my opinion the subcategory "Dialup" is correct and it describes what it does. Dialup is not limited to phone/modem terms. But if we would ask younger people, they may indeed vote for an entire new subcategory instead, called "AnonTools"... :smile:

• https://specifications.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry

On the other hand, choosing all needed categories seems more a package maintainer job then upstream due in fact they may be distribution specific.

Just an openSUSE example:

... Despite the above, /usr/lib/rpm/brp-suse.d/brp-30-desktop strictly enforces to always have at least one category followed by a subcategory. A correct minimal line looks like this: Categories=Graphics;2DGraphics;

• https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories#Network

@jwijenbergh I checked this on openSUSE and protonvpn-gui in the main repo. It hasn't a second category for example: /usr/share/applications/protonvpn.desktop:Categories=Network; :thinking:

However, the only similarity between the two applications is the used kind of technology. The main purpose of the applications differs.

[jwijenbergh]

Thanks for the detailed explanation @reneum, let's be okay with these categories