search

edvin / fxlauncher

Auto updating launcher for JavaFX Applications
Apache License 2.0
714 stars 110 forks source link

Application parameter with whitespaces #112

Open fjtorres opened 6 years ago

fjtorres commented 6 years ago

I detected a problem with application parameters, if you want to use application parameters with whitespaces the current implementation cannot process it. Currently the LauncherParams class try to split using "\s" and this is a problem if you want to pass something like this --appName="My app name". I tried to fix it by myself to do a pull request but for now I didn't find the better way to fix this without external libraries like "commons-cli".

https://github.com/edvin/fxlauncher/blob/03bea5efc6b9d4123fe91837ffe109c2dc12a043/src/main/java/fxlauncher/LauncherParams.java#L32

fjtorres commented 6 years ago

After another revision I don't understand why the LauncherParams class are reading parameter from manifest, the "delegate" parameter contains the parameters from the first call. Maybe just removing FXLauncher parameters form "delegate" is a better solution.