edvin / fxlauncher

Auto updating launcher for JavaFX Applications
Apache License 2.0
714 stars 110 forks source link

Integration with Github releases #79

Open 0legg opened 7 years ago

0legg commented 7 years ago

In general, it adds lot of friction to deploy app and all required metadata. You have to:

It can be overkill to set up some complicated flow to keep all stuff in sync and deploy it running one single command.

I have following suggestion to discuss. Right now, Github has it's own way to distribute apps: Releases. There are few ways to manage it:

In general, it'll lead to following actions to do:

If plans like this aligns well with your vision of project, I can help with implementation.

edvin commented 7 years ago

Honestly I don't feel that much friction from deployment, sure you need to set it up once, but after that it's a matter of running a build and it's done. That said, I absolutely see the value in the ability to deploy a GitHub release, and a PR for this functionality would be most welcome indeed :)

0legg commented 7 years ago

@edvin I'll hope to work on it soon. I'm not experienced with Maven plugins at all, so I'd like to start with Gradle counterpart, and then work on Maven (or even leave it to someone else to implement). I'd like to stick for now with v3 REST API — it looks much easier to implement without introducing dependencies to FxLauncher.

edvin commented 7 years ago

That sounds like a good idea. Gradle will be a little less involved anyways, and I can probably port it to Maven myself when things cool down a little here.