search

edvin / tornadofx-idea-plugin

TornadoFX Plugin for IntelliJ IDEA
Apache License 2.0
72 stars 20 forks source link

Fix crash in 2018.3 #83

Closed SiebelsTim closed 6 years ago

SiebelsTim commented 6 years ago

2018.3 renamed the options class. Therefore it cannot be found in newer versions of the IDE. It would be difficult to remain compatibility with both versions, therefore I removed the Options class and persist/read the data manually. We were using the Options only for the VIEW_CLASS_NAME.

fixes #82

edvin commented 6 years ago

Great work once again! Is it ready to be merged? I'll upload a new version of the plugin following this fix.

SiebelsTim commented 6 years ago

Yes I'd say so. I have tested both the new one and the old when, when compiling against them. I am not 100% sure it works when I compile against one of them, and try to install on the other though.

edvin commented 6 years ago

Seems good to me! I'll make a new release tonight :)

edvin commented 6 years ago

I'm unable to build for some reason, have you seen this error before?

FAILURE: Build failed with an exception.

* What went wrong:
Could not create service of type ScriptPluginFactory using BuildScopeServices.createScriptPluginFactory().
> Could not create service of type ResourceSnapshotterCacheService using GradleUserHomeScopeServices.createResourceSnapshotterCacheService().

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s
SiebelsTim commented 6 years ago

Haven't seen this one before. But it seems more like a gradle issue (I wonder how it's always you that has problems with gradle :D).

Try gradle --stop to restart the daemon, or rm ~/.gradle to remove gradle caches and settings. Also make sure you have access rights to that folder.

edvin commented 6 years ago

It worked from home :) I have a hate-hate relationship with Gradle!