edvin / tornadofx-idea-plugin

TornadoFX Plugin for IntelliJ IDEA
Apache License 2.0
73 stars 20 forks source link

Problems executing "convert all property to TornadoFx properties" #96

Open TioCoding opened 5 years ago

TioCoding commented 5 years ago

Hi, I'm trying to convert a 'data class' to a property object, but when I try to do it, IntelliJ freezes.

tornadofx

That is the moment in which we select the option to convert all the properties, but when selecting it, it loads but never ends.

captura de pantalla -2018-12-19 16-28-01

That's how intellij is frozen, and I have to force the closure by killing the instance.

I am doing something wrong? this is the class that I'm trying to convert:

package pe.com.clario.clariolibdomainfx.fxproperties

import java.time.LocalDateTime

data class AlmacenFX(val id: Int = -1,
                     val nombre: String? = null,
                     val status: Boolean? = null,
                     val descripcion: String? = null,
                     val idUserReg: Int? = null,
                     val fechaReg: LocalDateTime? = null,
                     val idUserMod: Int? = null,
                     val fechaMod: LocalDateTime? = null)
SiebelsTim commented 5 years ago

I'd argue that converting to JavaFxProperties in a data class wrong. In the end you'd have no parameters anymore, which is not allowed for data classes. The intention action would need to be more sophisticated for it.

Nevertheless, the plugin freezes on non-data classes as well an we'll fix it.