search

edvin / tornadofx

Lightweight JavaFX Framework for Kotlin
Apache License 2.0
3.68k stars 272 forks source link

CSS: cssclass datePickerPopUp's name is wrong #223

Closed codehz closed 7 years ago

codehz commented 7 years ago

it should be renamed to datePickerPopup

.date-picker-popup {
    -fx-background-color: -fx-box-border, -fx-control-inner-background;
    -fx-background-insets: 0, 1;
    /*-fx-background-radius: 0 6 6 6, 0 5 5 5;*/
    -fx-background-radius: 0;
    -fx-padding: 0;
    -fx-alignment: CENTER; /* VBox */
    -fx-spacing: 0; /* VBox */
    -fx-effect: dropshadow( three-pass-box , rgba(0,0,0,0.6) , 8, 0.0 , 0 , 0 );
}
edvin commented 7 years ago

The .date-picker-popup is not a pseudo class, just a normal css class. It is defined in the type safe stylesheet companion object like this:

val datePickerPopup by cssclass()

Hence, I'm not sure where you mean the name is wrong? It will render as .date-picker-popup.

codehz commented 7 years ago

@edvin I've misspelled.(s/pseudoclass/class/g)...I mean the class name is wrong...

edvin commented 7 years ago

See my comment above - it seems correct to me? Can you point to the file and line number you believe is wrong?

codehz commented 7 years ago

image it seems i am using old version....https://github.com/edvin/tornadofx/commit/f30b53377e8ccbf45e1d1ef505fb7ce0664dae8a#diff-b5e18ad9686d4414469c097c00d5bce1

edvin commented 7 years ago

Ah, that explains it :) Sorry, I wasn't aware that it was wrong previously. 1.5.9 was released today, btw :)