search

edvin / tornadofx

Lightweight JavaFX Framework for Kotlin
Apache License 2.0
3.68k stars 272 forks source link

javafx.css.CssParser #587

Open vlipovetskii opened 6 years ago

vlipovetskii commented 6 years ago

I tried to compile no.tornado.fxsample.forms with JDK 9 (with classpath) -> Caused by: java.lang.ClassNotFoundException: com.sun.javafx.css.parser.CSSParser Root cause: In JDK 9 CSSParser is moved to javafx.css package. Please fix it.

edvin commented 6 years ago

TornadoFX is not yet compatible with Java 9. There wouldn't be much to gain at this point either, as we're writing our code in Kotlin. Right now, Java 9 mainly offers fresh bugs in JavaFX and not much else, so we're not going to rush the transition.

Romanow88 commented 6 years ago

@edvin I would imagine that building an executable with JLink and reduced startup times should make the migration a thing to consider?

edvin commented 6 years ago

@Romanow88 That will certainly be possible once we move to Java 9 :)

yay commented 6 years ago

What are your thoughts regarding JavaFx removal from JDK 11 onward? How they affect your TornadoFx plans/commitment?

edvin commented 6 years ago

I think it's a good thing. First of all, there is hope that it can/will move faster. Second, this makes it possible to fork and rewrite parts in Kotlin. This would make it possible to include the builders as actual functions instead of extension functions and get much tighter control. We could also fix some design bloopers and even fix long standing bugs more easily.

yay commented 6 years ago

Glad to hear that! I've also stumbled upon this today: https://goo.gl/Hd7od1 It's good to know there are people willing to contribute. It would be a shame if this fine piece of technology gets abandoned. I've been working on SPA web apps and JS frameworks (ExtJS) for the past several years, and there is no stability in this space. These days I'm working on a small app for personal use that will (hopefully) last more than a few years, which is the very reason why my choice fell on JVM/JavaFx. I find it very natural to learn and use and TornadoFx certainly helps with productivity and readability. I also appreciate the book you've written. Thanks for your comments!