search

edvin / tornadofx2

TornadoFX 2.0
Apache License 2.0
155 stars 41 forks source link

Kotlin 1.4.x #26

Open JacekWicka opened 3 years ago

JacekWicka commented 3 years ago

12 and this one may require changes in documentation i.e. https://edvin.gitbooks.io/tornadofx-guide/content/part1/11_Editing_Models_and_Validation.html

SKeeneCode commented 3 years ago

Kotlin versions above 1.3.72 seem to bring about a bug that we need to fix before merging this - see here: https://github.com/edvin/tornadofx/issues/1324

SKeeneCode commented 2 years ago

Just tried with Kotlin 1.5.21, Gradle 7.3.3 and JavaFX 17.0.1 and looks good. Might be able to jump to Kotlin 1.6 immediately. @JacekWicka mind if I make a PR to 1.0-candidate using your changes?

JacekWicka commented 2 years ago

@JacekWicka mind if I make a PR to 1.0-candidate using your changes?

I'm glad to hear, it's useful. Go on, please.