Rework binding function APIs

edvin / tornadofx2

TornadoFX 2.0

Apache License 2.0

154 stars 40 forks source link

Closed aleksandar-stefanovic closed 2 years ago

aleksandar-stefanovic commented 2 years ago

[X] Edited all bindings
[x] Added comments
[X] Added missing nonNullObjectBinding extension function
[X] Deleted private fun createObservableArray which has no usages anymore
[X] Moved the booleanListBinding function so that all "basic" binding functions are in the same place in code
[X] Refactored usages to reflect API changes
[X] Add binding functions for ObservableLists

SKeeneCode commented 2 years ago

Great stuff. Can you make/change this PR to merge in the new branch 1.0-candidate?

I'm thinking for now it's best to keep breaking changes off master. Once all the major changes have been made we can look into releasing onto maven.

aleksandar-stefanovic commented 2 years ago

Done ✅. I did it automatically through GitHub, hopefully it didn't break anything.

SKeeneCode commented 2 years ago

Looks good. Tests pass. Excellent work on the comments. Merging. closes #42