search

edvin / tornadofx2

TornadoFX 2.0
Apache License 2.0
155 stars 41 forks source link

version javafx #6

Closed SchweinchenFuntik closed 4 years ago

SchweinchenFuntik commented 4 years ago

Why is the minimum version of javafx 13? By what criteria was such a choice made?

ctadlock commented 4 years ago

Good question. I just pulled over what was was in v1.

@edvin thoughts?

edvin commented 4 years ago

Since JavaFX 11 is LTS, it might be good to go with that for now, unless it makes TornadoFX unusable with newer versions of JavaFX.

ctadlock commented 4 years ago

Is there a way to have this application driven? I'd like to use JavaFX 13 in my app, but not everyone will. Im not a Maven expert.

SchweinchenFuntik commented 4 years ago

version can be upgraded

SchweinchenFuntik commented 4 years ago

You can also make different modules for different versions, highlighting the basic features in the main core module. Now many do it

ruckustboom commented 4 years ago

Other than the fact that it's LTS, is there any reason to stick with 11? Since TFX doesn't follow any sort of release cadence (let alone an LTS version), I don't really see how that's helpful to us (or the users). Using the latest stable version will give better performance and more features, and since Java 11 there's no need for the JavaFX version to match the JDK version, so we shouldn't have any sort of compatibility issues.

SchweinchenFuntik commented 4 years ago

What optimizations does the new version provide (maximum fix bugs) ? You probably do not understand what LTS is, 13 is already outdated, now you need to use 14 more.

After version 11, reflection continues to close. Bug with dirtyCell not fixed at 11, https://github.com/edvin/tornadofx/issues/1236

Are you sure you are ready to be released every month? I see nothing that there are 13 versions, except for the pain of use

SchweinchenFuntik commented 4 years ago

What will happen to jdk10 branch?

edvin commented 4 years ago

That makes sense @ruckustboom - we can compile against the latest release that works well for us, and users can use whatever version they feel like. So - we target JavaFX 14 now then I guess?

edvin commented 4 years ago

@SchweinchenFuntik https://github.com/edvin/tornadofx2 is "the new jdk10" branch, from which we'll soon release version 2.0.0 :)

ruckustboom commented 4 years ago

@SchweinchenFuntik

The reflection changes are a good reason why we should go with the latest version. If we compile against 11, but a user wants to use a later version (for example, so they can use the new native rendering buffers or e-ink displays), they could run into issues we didn't account for, but if we compile against the latest, we don't have to worry about it.

Sure, if we don't go with LTS we should update to 14. My argument wasn't that we should stay on 13 (I specifically said latest stable, not 13), just that I don't see why we should stay on LTS. I do understand what LTS is. What in my comment made you think I don't?

I'm not sure what you mean "except for the pain of use". We don't need to release a new version of TFX every time a new JavaFX version comes out, just make sure when we release a version, it's using the latest stable.

@edvin That's my vote, though I'm definitely open to hearing if there's something I didn't think about that would make it a bad idea.

edvin commented 4 years ago

I agree with @ruckustboom, it doesn't really make any sense to stay with 11. Let's go for 14, and keep targeting the latest version that we can comfortably compile against.

SchweinchenFuntik commented 4 years ago

close the question?