search

edvinaskrucas / notification

Notification package for Laravel
MIT License
526 stars 98 forks source link

Namespace and tests #2

Closed robclancy closed 11 years ago

robclancy commented 11 years ago

Your namespace being your name is like... bad. Because I am never going to remember that. Remember other developers have to type out this stuff. Change it to a short version. Just Krucas?

For example my namespaces are being changed to Robbo from RobClancy just because it is easier to type.

And also, you planning on adding tests? I don't see any reason for me not to use this other than those 2 things.

edvinaskrucas commented 11 years ago

Hey, thanks. Took your advice and shorten namespace. Tests will be added later, need to read more about testing.

edvinaskrucas commented 11 years ago

Added 53 tests with 141 assertions.