search

edvinaskrucas / notification

Notification package for Laravel
MIT License
525 stars 99 forks source link

Notification Group ShowAll throws Array to string conversion exception #62

Closed syphernl closed 8 years ago

syphernl commented 8 years ago

We've upgraded this module from 5.0 to 5.1 in our application without any other changes (config, blade etc) but this particular part is now causing issues:

{!! Notification::group('info', 'success', 'error', 'warning')->showAll() !!}

The exception is being caused in src/Krucas/Notification/NotificationsBag.php on line 452 which contains:

$output .= $message->render();
edvinaskrucas commented 8 years ago

Please consider to reconfigure package at first, as configuration has changed.

syphernl commented 8 years ago

With a fresh config it does indeed work. Based on the single sentence in the changelog "Improved configuration options" it wasn't clear that so much had changed which would result in exceptions like I was having.

But its solved now, thanks!

atwright147 commented 8 years ago

This should be documented!