search

edvinaskrucas / notification

Notification package for Laravel
MIT License
526 stars 98 forks source link

these are some problems to config in laravel5 #64

Closed Salon-sai closed 8 years ago

Salon-sai commented 8 years ago

I write the composer.json with

"edvinaskrucas/notification": "5.*"

and hit composer update.It is just ok, but when I register to use it and write

Krucas\Notification\NotificationServiceProvider::class, 'Notification' => Krucas\Notification\Facades\Notification::class

in app.php , the laravel5 throw the exception with Call to undefined method Illuminate\View\Compilers\BladeCompiler::directive()

If there is any problem it on my configuration? thank!

atwright147 commented 8 years ago

Same problem here.

I think v5.1 just doesn't support Laravel 5.0. Change your composer declaration to "edvinaskrucas/notification": "5.0.0" and run composer update.

@edvinaskrucas your composer.json in v5.1.0 needs to specify Laravel <= 5.1 not 5.0

Salon-sai commented 8 years ago

thx to @atwright147 . laravel 5.0 require notification 5.0.0

atwright147 commented 8 years ago

Hey @Salon-sai,

Please re-open this issue. You have simply worked around the problem but the problem is still there. The composer.json file needs to be more specific.

Andy