edvinaskrucas / notification

Notification package for Laravel

MIT License

526 stars 98 forks source link

fixed notifications for 5.4 #82

Closed pollend closed 6 years ago

Kyslik commented 7 years ago

Would you mind changing also readme?

pollend commented 7 years ago

In what regard? I just need this working for a project.

pollend commented 7 years ago

@Kyslik what is your plan in regards to this repository? The maintainer seems to have disappeared from the face of the earth.

edvinaskrucas commented 7 years ago

Hey, sorry for me not being active on this, I'll try to find some time to fix issues and upgrade it to newest laravel.

Harrisonbro commented 7 years ago

In case folks are interested, I've also created a pull request #84 which fixes this package for Laravel 5.4 with more minimal changes (specifically, it doesn't introduce a FlashEvent class).

@edvinaskrucas #84 also includes a test repository and written instructions to help you replicate the bug and verify that this PR fixes the issue.

Harrisonbro commented 7 years ago

84 has now been merged which fixes the same issue as this PR. It may therefore be appropriate to close this PR.