Fixes Laravel 5.4 wildcard event listening signature change

edvinaskrucas / notification

Notification package for Laravel

MIT License

525 stars 99 forks source link

Fixes Laravel 5.4 wildcard event listening signature change #84

Closed Harrisonbro closed 7 years ago

Harrisonbro commented 7 years ago

Laravel 5.4 has changed the way wildcard event subscribers work. They now receive the event name as their first argument and the array of event data as their second argument, meaning the method signature of Krucas\Notification\Subscriber::onFlash no longer works. This same issue has also been noted in #81.

This pull request fixes this issue.

I've created a repository and written instructions to help you replicate the bug and verify that this PR fixes the issue.

emielmolenaar commented 7 years ago

PHP 5.5 should be removed from .travis.yml to make the tests pass.

emielmolenaar commented 7 years ago

Awesome, now we need @edvinaskrucas to merge this stuff :wink:

emielmolenaar commented 7 years ago

Hooray! Thanks @edvinaskrucas !

edvinaskrucas commented 7 years ago

@emielmolenaar thanks for your support!

emielmolenaar commented 7 years ago

And thanks @Harrisonbro for the PR :smile: !