edward-shen / MMM-MBTA

MagicMirror² module for the Massachusetts Bay Transportation Authority
MIT License
12 stars 4 forks source link

Commuter Rail - Backbay, SouthStation, NorthStation missing #15

Open gmichaela opened 6 years ago

gmichaela commented 6 years ago

Looks like Back bay and South Station stops are only on the T, I'll research adding them to the commuter rail lists. To make them more useful, on the outbound side, you need to know which destination-line you typically go to as well.

Thanks for starting this module!

edward-shen commented 6 years ago

Honestly, the data that was fetched was from an relatively old dataset, so I think new changes won't be present.

As mentioned in #5, this module isn't actively developed, but feel free to make a PR and I'll happily review/merge it!

gmichaela commented 6 years ago

May not be a big deal, if you are leaving from a major hub station and don't really know/care your typical destination it may be. Looks like putting in your start/ending station into the config actually does most of what it needs to do... even when you primarily use South Station/North Station on a particular CR line...

As of right now, this module is most useful when you a typically traveling from a particular station to an end terminal point -- Starting to think about enhancements to the Stations array to support a start/end Station or multiple start/end stations...

nakulbende commented 4 years ago

Hello - I actually have a solution which can let you add any bus stop/ train stop - even detours. Suppose you were looking for a random station, which is not in the list - just search it in MBTA website. The url actually contains the number code for that stop - https://www.mbta.com/stops/9229 is stop # 9229. Now edit your stations-formatted.json and append a line:

"Main St @ E Emerson St": "9229",

And - it works!!!

image

PS: @edward-shen - thanks for making the module! Perhpas you can add the above instructions to the readme!

edward-shen commented 4 years ago

Hi, thanks for the suggestion. Unfortunately I'm unable to reproduce your example: For example, if I search for Alewife, I get https://www.mbta.com/stops/place-alfcl instead of a number. Mind providing more exact steps?

nakulbende commented 4 years ago

I don't think all the stations have number. Like Davis.

------------Sent from phone----------

Nakul Bende,

Materials Scientist, Formlabs Inc.

http://nakulbende.com

On Mon, Feb 17, 2020, 12:56 PM Edward Shen notifications@github.com wrote:

Hi, thanks for the suggestion. Unfortunately I'm unable to reproduce your example: For example, if I search for Alewife, I get https://www.mbta.com/stops/place-alfcl instead of a number. Mind providing more exact steps?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/edward-shen/MMM-MBTA/issues/15?email_source=notifications&email_token=ACCO64T7WDRWR7T2BADOW63RDLFVPA5CNFSM4GFMO522YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL7H3YQ#issuecomment-587103714, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCO64WSPXISXI5IXIIJL4DRDLFVPANCNFSM4GFMO52Q .

edward-shen commented 4 years ago

Oh, sorry, you're right. It's been a while since I've looked at this.

I'll add your instructions to the readme.

nakulbende commented 4 years ago

Thanks for main by the module! I have 4 stations in my mirror

------------Sent from phone----------

Nakul Bende,

Materials Scientist, Formlabs Inc.

http://nakulbende.com

On Tue, Feb 18, 2020, 3:33 PM Edward Shen notifications@github.com wrote:

Oh, sorry, you're right. It's been a while since I've looked at this.

I'll add your instructions to the readme.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/edward-shen/MMM-MBTA/issues/15?email_source=notifications&email_token=ACCO64QDVJR3C2QCM25H7ATRDRAYDA5CNFSM4GFMO522YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMER5FA#issuecomment-587800212, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCO64Q4K2OKSVXLWYTOMITRDRAYDANCNFSM4GFMO52Q .