search

edward-shen / MMM-pages

Add pages to your MagicMirror²!
MIT License
109 stars 29 forks source link

Does this do some kind of overlay in background? #52

Closed AshDarko closed 3 years ago

AshDarko commented 3 years ago

first of all thanks for your time and effort on this module :)

I have installed this and got this working as intended for now.

And just wondering does it override the "fullscreen_above" position?

Only reason I ask, and its seasonal, is I have MMM-Snow for the kids installed, and the snowflakes seem to fall behind this, instead of in front like they used to before i installed this.

So I guess, any way to make your layer transparent or...?

No biggy

I have no errors reported, and am on the latest MM

edward-shen commented 3 years ago

I have MMM-Snow for the kids installed,

Thats adorable!

MMM-pages doesn't mess around with anything like that and it only asks MM to hide and show modules. Any change in behavior would probably be a bug on the module instead, not MMM-Pages. MMM-pages doesn't have a layer, so to speak.

You can try changing the CSS for MMM-snow and increase the z-index (I believe a higher value is shown on top), but this might be worth filing an issue there as well for visibility. Im not sure how MMM-snow works, so it's probably best to consult their Readme instead.

Alternatively try making it a fixed module, maybe that might fix it?

AshDarko commented 3 years ago

Hi! yeah I tried a custom CSS zindex on snow to put it at 1000 and no joy.

Will ask over there too. Thank you for your quick reply!

So yours doesn't add a layer for the page or anything like that?

On Wed, 9 Dec 2020, 22:17 Edward Shen, notifications@github.com wrote:

I have MMM-Snow for the kids installed,

Thats adorable!

MMM-pages doesn't mess around with anything like that and it only asks MM to hide and show modules. Any change in behavior would probably be a bug on the module instead, not MMM-Pages.

You can try changing the CSS for MMM-snow and increase the z-index (I believe a higher value is shown on top), but this might be worth filing an issue there as well for visibility. Im not sure how MMM-snow works, so it's probably best to consult their Readme instead.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/edward-shen/MMM-pages/issues/52#issuecomment-742098500, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALOYYIL4O5OJFYDOGYEQ6RTST7ZQTANCNFSM4UUEAHUQ .

edward-shen commented 3 years ago

Yeah, it doesn't. MMM-pages is just a really fancy way to just ask modules to hide and show themselves all at the same time so they look like they're on a page together :)

AshDarko commented 3 years ago

thank you again :)

AshDarko commented 3 years ago

I found it, in your pages.css you have a z-index of -1 which is causing the issue :)

edward-shen commented 3 years ago

Oh my god, I've completely forgotten about that... When I get a chance I'll pull out that change. In hindsight we really shouldn't be doing something like that, even if it does fix a problem that a user had before.

Sorry for leading you down the wrong path!

AshDarko commented 3 years ago

Thats fine no worries! Glad I found it and hope it helps :)

edward-shen commented 3 years ago

Alright, I've pulled out the changes in pages.css. Thanks again for helping out!