search

edward0429 / arduino

Automatically exported from code.google.com/p/arduino
0 stars 0 forks source link

Suppress warnings #688

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Lots of warnings have been cleaned up, but there are a few more.  Attached 
patches clean then up.  

Patch #4 may be controversial, as it redefines PROGMEM.  This is the suggested 
workaround from the GNU bug tracker.  Also, the bug has finally been fixed in 
avr-gcc so will hopefully start showing up in avr-gcc releases.

Original issue reported on code.google.com by maniac...@ymail.com on 22 Oct 2011 at 9:13

Attachments:

GoogleCodeExporter commented 9 years ago 
I tried the same approach of redefining PROGMEM, and found that it has the same 
problem as declaring the variable extern before defining it: both are illegal 
to use for declaring variables inside functions. The best way is to upgrade the 
compiler. My attempt to compile avr-gcc 4.6.2 so far failed though.

See
https://savannah.nongnu.org/bugs/index.php?28837
https://savannah.nongnu.org/bugs/index.php?34680

Original comment by gooc...@top.geek.nz on 30 Oct 2011 at 8:52

GoogleCodeExporter commented 9 years ago 
I'm not seeing most of these.  Maybe some were fixed by other patches?

Original comment by dmel...@gmail.com on 30 Dec 2011 at 11:19

GoogleCodeExporter commented 9 years ago 
Just did a clean build on a fresh pull.  Build output attached.  Turn on -Wall 
-Werror to see them all.

Original comment by maniac...@ymail.com on 31 Dec 2011 at 12:27

Attachments:

GoogleCodeExporter commented 9 years ago 
I fixed most of these:

https://github.com/arduino/Arduino/commit/c441bc1a0df2b07422cc1fe0c2ec8b3dc027d2
53
https://github.com/arduino/Arduino/commit/cce4ef7c6932c8d93c180ce7990261223e490d
63

Honestly, though, most of them weren't even showing up for me at all (even with 
-Wall) so I probably skipped some.

Original comment by dmel...@gmail.com on 2 Jan 2012 at 6:10

GoogleCodeExporter commented 9 years ago

Original comment by dmel...@gmail.com on 21 May 2012 at 4:00