Faker.js should be in peer dependencies

edwardanthony / nestjs-seeder

An extension library for NestJS to perform seeding.

MIT License

102 stars 21 forks source link

Closed omer-morad-ni closed 2 years ago

omer-morad-ni commented 3 years ago

Hi,

Wanted to say this a great package! You did excellent work here!

The "faker": "^4.1.0" should be in the peer dependencies because you need to let the consumer determine the version of Faker.

Want me to create a PR for it?

edwardanthony commented 3 years ago

Thank you! Sorry for the late reply. I was on new year holiday. Sure, a PR would be really helpful.