search

edwardanthony / nestjs-seeder

An extension library for NestJS to perform seeding.
MIT License
102 stars 21 forks source link

Faker version outdated #35

Closed hox closed 1 year ago

hox commented 1 year ago

Could this package be updated to allow @faker-js/faker version ^8.0.0?

edwardanthony commented 1 year ago

Hi I made faker js a peer dependency so you can choose your own faker js version. Is there any breaking changes that prevent you from doing that? Please kindly let me know. Thanks.

hox commented 1 year ago

Thanks for the super fast reply! The peer dep requires faker-js ^7.5.0, which means 8.0.0 is not allowed. In order for me to use it, I would have to force the version: image

edwardanthony commented 1 year ago

I'll bump the version number. I'll have to ask you to wait for me to finish the test to make sure it does not break anything.

hox commented 1 year ago

Thank you very much!

edwardanthony commented 1 year ago

Hi Elias, I've deployed a new patch version 0.3.2. Please let me know if the new version resolves your issue. If there's nothing else, I'll close this thread.

hox commented 1 year ago

I have installed the new version and all is well, I appreciate your help and very fast action on this issue. You're the best!

Thanks :)

edwardanthony commented 1 year ago

No worries. I'd appreciate if you can leave a star in the Github repo 🙏.