edwardcapriolo / teknek

12 stars 4 forks source link

Integrate yammer metrics #19

Closed edwardcapriolo closed 10 years ago

edwardcapriolo commented 10 years ago

Currently we have been leaving it up to the operators to BYOM (bring your own metrics) this gets redundant and it makes sense for us to integrate coda-hale /yammer.

We will bootstrap metrics in the teknek startup and pass this registry into all operators and feeds. This will make it super easy to have application side counters and publish this information to graphite.

edwardcapriolo commented 10 years ago

To expand on this there are several cases to cover:

Passing MetricRegistry to Operator and Feeds. This will allow the author to provide their own counters.

Providing a "plan path". Just being the "plus1 operator " is not enough. Imagine if the "plus1" operator is used inside two separate plans. We need to know that we are "plan1.plus1.plus1" operator as well.

Thread/feed specific counters. Maybe we are running 3 instances of "Plus1" operator in three threads and one of those is slow. We also need a steady number/id so that we can record counters per feed.

It would be nice if some counters were auto-magic messages consumed without the user having to deal with it. We could make a base class for this or handle this in the framework may punt on this issue for now.

edwardcapriolo commented 10 years ago

Resolved in https://github.com/edwardcapriolo/teknek-core/pull/11