edwardchalstrey1 / seshat

This is the beginning of the Seshat Project code.
0 stars 2 forks source link

Update code to work with Cliopatria "composite" shapes (04062024) #107

Closed edwardchalstrey1 closed 2 months ago

edwardchalstrey1 commented 2 months ago

Info:

From Jim Bennett:

Note this version has the ‘composite’ shapes with names that are surrounded by ()’s.
Ed, this may mess things up for you. In particular you will get both ‘(Roman Empire)’ and ‘Roman Empire’. The later is the low-level shape; you’ll want to display the (Roman Empire) composite versions instead. This might require a two-pass alg, the first to find those names and them drop the equivalent unadorned versions on the internment pass. You might also want to strip the leading and trailing parens. (Note that there are sometimes internal parens, e.g., our old friend ‘Peithon (son of Agenor)’ so just don’t .replace(‘(‘,’’).replace(‘)’,’’)!)

edwardchalstrey1 commented 2 months ago

I think what he means is that there will be some "low level" shapes that belong to multiple polities, but doing it this way avoids the #108 situation. The result will mean that some of the low level shapes will be represented twice in the same year, resulting in an overlap of polities - which is actually good because that makes sense and is what we're trying to represent by saying a low level shape (a region) is part of both polities

edwardchalstrey1 commented 2 months ago

Closed by #114